chrome/browser/resources/md_history/history_card.js - Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_card.js

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Address reviewer comments: add tests for deletion and logic for supervised users. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history_card.html ('K') | « chrome/browser/resources/md_history/history_card.html ('k') | chrome/browser/resources/md_history/history_card_manager.js » ('j') | chrome/browser/resources/md_history/history_card_manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history_card.js

diff --git a/chrome/browser/resources/md_history/history_card.js b/chrome/browser/resources/md_history/history_card.js

index 542a6d9ecd8a8645bbd1ffc474d9d8b5d10d2510..41ff05475c77495d26247ec9a8526e8bfbdd2e4e 100644

--- a/chrome/browser/resources/md_history/history_card.js

+++ b/chrome/browser/resources/md_history/history_card.js

@@ -23,10 +23,12 @@ Polymer({

* Check whether the time difference between the given historyItem and the

* next one is large enough for a spacer to be required.

* @param {number} index The index number of the first item being compared.

+ * @param {number} itemsLength The number of items on the card. Used to force

+ * needsTimeGap_ to run for every item if an item is deleted from the card.

* @return {boolean} Whether or not time gap separator is required.

* @private

- needsTimeGap_: function(index) {

+ needsTimeGap_: function(index, itemsLength) {

var items = this.historyItems;

return index + 1 < items.length &&

items[index].time - items[index + 1].time > BROWSING_GAP_TIME;