chrome/browser/resources/md_history/history_card.html - Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_card.html

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Address reviewer comments: add tests for deletion and logic for supervised users. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history.js ('K') | « chrome/browser/resources/md_history/history.js ('k') | chrome/browser/resources/md_history/history_card.js » ('j') | chrome/browser/resources/md_history/history_card_manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history_card.html

diff --git a/chrome/browser/resources/md_history/history_card.html b/chrome/browser/resources/md_history/history_card.html

index 18b9cf8eb88094a121610122aa7f7828fea4aece..f04b99abdd824abaeef413f93fe8cfa0f96120c3 100644

--- a/chrome/browser/resources/md_history/history_card.html

+++ b/chrome/browser/resources/md_history/history_card.html

@@ -54,10 +54,10 @@

website-domain="{{historyItem.domain}}"

website-url="{{historyItem.url}}"

starred="{{historyItem.starred}}"

- selected="{{historyItem.selected}}"

- timestamp="{{historyItem.time}}">

calamity 2016/01/21 00:11:08 Why did this disappear?

hsampson 2016/01/21 05:34:46 Because it wasn't isn't being used yet, and later

+ selected="{{historyItem.selected}}">

</history-item>

- <template is="dom-if" if="{{needsTimeGap_(index, historyItem)}}">

+ <template is="dom-if"

+ if="{{needsTimeGap_(index, historyItems.length)}}">

</template>