MD History: Delete button in the toolbar allows deletion of multiple history-items.

chrome/browser/resources/md_history/history_card.html

Index: chrome/browser/resources/md_history/history_card.html
diff --git a/chrome/browser/resources/md_history/history_card.html b/chrome/browser/resources/md_history/history_card.html
index 706da7fc406471b9dac69d49eaee53b9cc589304..e9b9b674acf7ff3dc1c478c6d488243b0c230dea 100644
--- a/chrome/browser/resources/md_history/history_card.html
+++ b/chrome/browser/resources/md_history/history_card.html
@@ -57,7 +57,8 @@
               selected="{{historyItem.selected}}"
               timestamp_="[[historyItem.time]]">
           </history-item>
-          <template is="dom-if" if="[[needsTimeGap_(index, historyItem)]]">
+          <template is="dom-if"
+              if="[[needsTimeGap_(index, historyItems.length)]]">

[calamity, 2016/02/02 05:34:58]

Does this function correctly if the actual item is changed then (i.e does
needsTimeGap_ run when the historyItems array length doesn't change but the
actual item being rendered does)? (This happens when cards are swapped in during
the infinite scroll, which is why we needed historyItem here in the first place)

#IfYouLikeItThenYouShouldHaveWroteATestForIt

[hsampson, 2016/02/02 22:59:53]

I haven't found any errors just scrolling but I think you are right here.

[calamity, 2016/02/03 02:10:50]

Can you write a regression test that recreates the issue and then verify that
having historyItem here fixes it?

             <div id="time-gap-separator"></div>
           </template>
         </template>