Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Side by Side Diff: chrome/browser/resources/md_history/history_card.html

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Address reviewer comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/shadow.htm l">
4 <link rel="import" href="chrome://history/history_item.html"> 4 <link rel="import" href="chrome://history/history_item.html">
5 5
6 <dom-module id="history-card"> 6 <dom-module id="history-card">
7 <template> 7 <template>
8 <style> 8 <style>
9 :host { 9 :host {
10 @apply(--layout-center); 10 @apply(--layout-center);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 <template is="dom-repeat" items="[[historyItems]]" 50 <template is="dom-repeat" items="[[historyItems]]"
51 as="historyItem"> 51 as="historyItem">
52 <history-item time-accessed_="[[historyItem.dateTimeOfDay]]" 52 <history-item time-accessed_="[[historyItem.dateTimeOfDay]]"
53 website-title_="[[historyItem.title]]" 53 website-title_="[[historyItem.title]]"
54 website-domain_="[[historyItem.domain]]" 54 website-domain_="[[historyItem.domain]]"
55 website-url_="[[historyItem.url]]" 55 website-url_="[[historyItem.url]]"
56 starred="[[historyItem.starred]]" 56 starred="[[historyItem.starred]]"
57 selected="{{historyItem.selected}}" 57 selected="{{historyItem.selected}}"
58 timestamp_="[[historyItem.time]]"> 58 timestamp_="[[historyItem.time]]">
59 </history-item> 59 </history-item>
60 <template is="dom-if" if="[[needsTimeGap_(index, historyItem)]]"> 60 <template is="dom-if"
61 if="[[needsTimeGap_(index, historyItems.length)]]">
calamity 2016/02/02 05:34:58 Does this function correctly if the actual item is
hsampson 2016/02/02 22:59:53 I haven't found any errors just scrolling but I th
calamity 2016/02/03 02:10:50 Can you write a regression test that recreates the
61 <div id="time-gap-separator"></div> 62 <div id="time-gap-separator"></div>
62 </template> 63 </template>
63 </template> 64 </template>
64 </div> 65 </div>
65 </div> 66 </div>
66 </template> 67 </template>
67 <script src="chrome://history/history_card.js"></script> 68 <script src="chrome://history/history_card.js"></script>
68 </dom-module> 69 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698