tools/battor_agent: Prints real BattOr samples instead of raw ones

tools/battor_agent: Prints real BattOr samples instead of raw ones

BUG=542837
Committed: https://crrev.com/373d14fff4cd98c3a725b068882967c828c5c700
Cr-Commit-Position: refs/heads/master@{#369767}

[charliea (OOO until 10-5), 2016-01-14 17:56:16]

Patchset #1 (id:1) has been deleted

[charliea (OOO until 10-5), 2016-01-14 17:56:30]

charliea@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2016-01-14 22:41:19]

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_agent.cc (right):

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_agent.cc:409: std::string
BattOrAgent::SamplesToString() {
Do we have test coverage for this?

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_sample_converter.cc (right):

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_sample_converter.cc:80: current /= eeprom_.r1;
Can we ever have divison by zero?

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_sample_converter.cc:89: double time_ms =
double(sample_number) / eeprom_.sd_sample_rate * 1000;
Similar

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_sample_converter.h (right):

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_sample_converter.h:30: // Converts a raw sample to a
unitful one with a timestamp.
What does "unitful" mean?

[charliea (OOO until 10-5), 2016-01-15 01:51:22]

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_agent.cc (right):

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_agent.cc:409: std::string
BattOrAgent::SamplesToString() {
On 2016/01/14 22:41:19, nednguyen wrote:
> Do we have test coverage for this?

Done.

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_sample_converter.cc (right):

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_sample_converter.cc:80: current /= eeprom_.r1;
On 2016/01/14 22:41:19, nednguyen wrote:
> Can we ever have divison by zero?

Nope - the current is sensed through a resistor which is guaranteed to have a
resistance.

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_sample_converter.cc:89: double time_ms =
double(sample_number) / eeprom_.sd_sample_rate * 1000;
On 2016/01/14 22:41:19, nednguyen wrote:
> Similar

Nope - we're guaranteed to have more than zero samples/second.

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
File tools/battor_agent/battor_sample_converter.h (right):

https://codereview.chromium.org/1586173002/diff/20001/tools/battor_agent/batt...
tools/battor_agent/battor_sample_converter.h:30: // Converts a raw sample to a
unitful one with a timestamp.
On 2016/01/14 22:41:19, nednguyen wrote:
> What does "unitful" mean?

It's a math-y/physics-y word meaning a number with units attached to it. The
"calibrated" word that this was previously was accidentally left over from when
I originally named this class a "BattOrSampleCalibrator"

[nednguyen, 2016-01-15 02:07:20]

lgtm

[charliea (OOO until 10-5), 2016-01-15 02:13:58]

The CQ bit was checked by charliea@chromium.org

[commit-bot: I haz the power, 2016-01-15 02:14:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586173002/40001

[commit-bot: I haz the power, 2016-01-15 02:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 02:21:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nednguyen, 2016-01-15 05:45:51]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-01-15 05:46:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586173002/40001

[commit-bot: I haz the power, 2016-01-15 05:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 05:55:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[charliea (OOO until 10-5), 2016-01-15 16:07:13]

The CQ bit was checked by charliea@chromium.org

[charliea (OOO until 10-5), 2016-01-15 16:07:13]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1586173002/#ps60001
(title: "Fixed size_t build error")

[commit-bot: I haz the power, 2016-01-15 16:07:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586173002/60001

[commit-bot: I haz the power, 2016-01-15 16:37:55]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-15 16:39:17]

Description was changed from

==========
tools/battor_agent: Prints real BattOr samples instead of raw ones

BUG=542837
==========

to

==========
tools/battor_agent: Prints real BattOr samples instead of raw ones

BUG=542837

Committed: https://crrev.com/373d14fff4cd98c3a725b068882967c828c5c700
Cr-Commit-Position: refs/heads/master@{#369767}
==========

[commit-bot: I haz the power, 2016-01-15 16:39:18]

Patchset 3 (id:??) landed as
https://crrev.com/373d14fff4cd98c3a725b068882967c828c5c700
Cr-Commit-Position: refs/heads/master@{#369767}