tools/battor_agent: Prints real BattOr samples instead of raw ones

tools/battor_agent/battor_sample_converter.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_BATTOR_AGENT_BATTOR_SAMPLE_CONVERTER_H_
 #define TOOLS_BATTOR_AGENT_BATTOR_SAMPLE_CONVERTER_H_
 
 #include <vector>
 
 #include "tools/battor_agent/battor_protocol_types.h"
 
 namespace battor {
 
 // Converter capable of taking raw samples from the BattOr and using
 // configuration information to turn them into samples with real units.
 class BattOrSampleConverter {
  public:
   // Constructs a BattOrSampleConverter.
   //
   //   - eeprom: The BattOr's EEPROM, which contains some required conversion
   //     parameters.
   //   - calibration_frame: The first frame sent back from the BattOr when
   //     streaming samples. This frame gives current and voltage measurements
   //     that ignore whatever the BattOr's connected to, and therefore provide
   //     a means for us to determine baseline current and voltage.
   BattOrSampleConverter(const BattOrEEPROM& eeprom,
                         const std::vector<RawBattOrSample>& calibration_frame);
   virtual ~BattOrSampleConverter();
 
-  // Converts a raw sample to a calibrated one.
-  BattOrSample ToSample(const RawBattOrSample& sample) const;
+  // Converts a raw sample to a unitful one with a timestamp.

[nednguyen, 2016/01/14 22:41:19]

What does "unitful" mean?

[charliea (OOO until 10-5), 2016/01/15 01:51:21]

It's a math-y/physics-y word meaning a number with units attached to it. The
"calibrated" word that this was previously was accidentally left over from when
I originally named this class a "BattOrSampleCalibrator"

+  BattOrSample ToSample(const RawBattOrSample& sample,
+                        size_t sample_number) const;
 
  private:
   // The BattOr's EEPROM, which stores some conversion parameters we need.
   BattOrEEPROM eeprom_;
 
   // The baseline current and voltage calculated from the calibration frame.
   double baseline_current_;
   double baseline_voltage_;
 };
 
 }  // namespace battor
 
 #endif  // TOOLS_BATTOR_AGENT_BATTOR_SAMPLE_CONVERTER_H_