build/config/sanitizers/sanitizers.gni - Issue 1586123009: GN(android) Remove assert that is_asan requires is_component_build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 1586123009: GN(android) Remove assert that is_asan requires is_component_build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/sanitizers/sanitizers.gni

diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni

index f8f469c97c954f556fe298d36e9d6b13216ac39f..07950113f80da371a0e95fd38c51da6252ec3221 100644

--- a/build/config/sanitizers/sanitizers.gni

+++ b/build/config/sanitizers/sanitizers.gni

@@ -89,6 +89,3 @@ assert(!using_sanitizer || is_clang,

assert(

!is_debug || !(is_msan || is_lsan || is_tsan || is_ubsan || is_ubsan_vptr),

"Sanitizers should generally be used in release (set is_debug=false).")

-assert(!(is_android && is_asan && !is_component_build),

- "is_asan on Android requires is_component_build to be set")

« no previous file with comments | « no previous file | no next file » | no next file with comments »