build/config/sanitizers/sanitizers.gni - Issue 1586123009: GN(android) Remove assert that is_asan requires is_component_build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 1586123009: GN(android) Remove assert that is_asan requires is_component_build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 declare_args() {

6 # Compile for Address Sanitizer to find memory bugs.	6 # Compile for Address Sanitizer to find memory bugs.

7 is_asan = false	7 is_asan = false

8	8

9 # Compile for Leak Sanitizer to find leaks.	9 # Compile for Leak Sanitizer to find leaks.

10 is_lsan = false	10 is_lsan = false

(...skipping 71 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
82 # If you find a use-case where you want to compile a sanitizer in debug mode	82 # If you find a use-case where you want to compile a sanitizer in debug mode

83 # and have verified it works, ask brettw and we can consider removing it from	83 # and have verified it works, ask brettw and we can consider removing it from

84 # this condition. We may also be able to find another way to enable your case	84 # this condition. We may also be able to find another way to enable your case

85 # without having people accidentally get broken builds by compiling an	85 # without having people accidentally get broken builds by compiling an

86 # unsupported or unadvisable configurations.	86 # unsupported or unadvisable configurations.

87 #	87 #

88 # For one-off testing, just comment this assertion out.	88 # For one-off testing, just comment this assertion out.

89 assert(	89 assert(

90 !is_debug \|\| !(is_msan \|\| is_lsan \|\| is_tsan \|\| is_ubsan \|\| is_ubsan_vptr),	90 !is_debug \|\| !(is_msan \|\| is_lsan \|\| is_tsan \|\| is_ubsan \|\| is_ubsan_vptr),

91 "Sanitizers should generally be used in release (set is_debug=false).")	91 "Sanitizers should generally be used in release (set is_debug=false).")

92

93 assert(!(is_android && is_asan && !is_component_build),

94 "is_asan on Android requires is_component_build to be set")

OLD	NEW