Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1586123009: GN(android) Remove assert that is_asan requires is_component_build (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android) Remove assert that is_asan requires is_component_build I had fixed this previously but forgot to remove the assert. BUG=578198 Committed: https://crrev.com/dd50c5a02f86af2801ff5e425f9c15533da24105 Cr-Commit-Position: refs/heads/master@{#370123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/config/sanitizers/sanitizers.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/01/15 21:36:59, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org padding your stats.
4 years, 11 months ago (2016-01-15 21:37:06 UTC) #3
Yaron
lgtm
4 years, 11 months ago (2016-01-15 21:37:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586123009/1
4 years, 11 months ago (2016-01-19 15:51:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 16:21:17 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 16:22:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd50c5a02f86af2801ff5e425f9c15533da24105
Cr-Commit-Position: refs/heads/master@{#370123}

Powered by Google App Engine
This is Rietveld 408576698