Implement ClassMirror.owner and LibraryMirror.uri.

Implement ClassMirror.owner and LibraryMirror.uri.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23211

[ahe, 2013-05-24 14:20:26]

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4045: //
TODO(ahe): This is only for reflection, and it is not correct yet.
FWIW, this is covered by the test "Test reflect type" in
dart/tests/lib/mirrors/mirrors_test.dart.

[Johnni Winther, 2013-05-27 05:38:49]

lgtm

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:26: if (uri.scheme
!= 'dart' || !uri.path.startsWith('_')) {
Please add a comment. Something like "Don't include members for private
libraries." I guess. And a about why.

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:16: import
'dart:_interceptors';
Why do you remove these?

[ahe, 2013-05-27 06:46:04]

Thank you, Johnni!

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/enqueue.dart:26: if (uri.scheme
!= 'dart' || !uri.path.startsWith('_')) {
On 2013/05/27 05:38:49, Johnni Winther wrote:
> Please add a comment. Something like "Don't include members for private
> libraries." I guess. And a about why.

Done.

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/15861005/diff/2001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:16: import
'dart:_interceptors';
On 2013/05/27 05:38:49, Johnni Winther wrote:
> Why do you remove these?

I needed most of interceptors imported.

[ahe, 2013-05-27 06:58:56]

I have discovered problems with deferred loading during testing.  I'll send
another note when I have a fix.

[ngeoffray, 2013-05-27 07:53:55]

https://codereview.chromium.org/15861005/diff/7001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/15861005/diff/7001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4046: value =
graph.addConstantNull(constantSystem);
How do you actually end up having a redirecting facctory body if it was an
assertion before? I did not see code in your CL that would trigger this.

[ahe, 2013-05-27 08:10:01]

https://codereview.chromium.org/15861005/diff/7001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/15861005/diff/7001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4046: value =
graph.addConstantNull(constantSystem);
On 2013/05/27 07:53:55, ngeoffray wrote:
> How do you actually end up having a redirecting facctory body if it was an
> assertion before? I did not see code in your CL that would trigger this.

This was because of wrong translation of !(a && b) in the enqueuer. Instead of
not enqueing private dart: libraries, I didn't enqueue any dart: libraries.

Once I started enqueing dart: libraries correctly, I all of a sudden need to
compile redirecting factories (as they may be invoked reflectively).

[ngeoffray, 2013-05-27 08:12:37]

https://codereview.chromium.org/15861005/diff/7001/dart/sdk/lib/_internal/com...
File dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/15861005/diff/7001/dart/sdk/lib/_internal/com...
dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4046: value =
graph.addConstantNull(constantSystem);
On 2013/05/27 08:10:01, ahe wrote:
> On 2013/05/27 07:53:55, ngeoffray wrote:
> > How do you actually end up having a redirecting facctory body if it was an
> > assertion before? I did not see code in your CL that would trigger this.
> 
> This was because of wrong translation of !(a && b) in the enqueuer. Instead of
> not enqueing private dart: libraries, I didn't enqueue any dart: libraries.
> 
> Once I started enqueing dart: libraries correctly, I all of a sudden need to
> compile redirecting factories (as they may be invoked reflectively).

I see, thanks for the explanation.

[ahe, 2013-05-27 10:26:15]

Uploaded patch set with fix for deferred code.  I'll submit the CL now, but I
would appreciate if you'd take another look.

Cheers,
Peter

[ahe, 2013-05-27 10:28:20]

Committed patchset #3 manually as r23211 (presubmit successful).