Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4184)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.js

Issue 1585963004: Settings People Revamp: Add tests for ChromeOS Change Picture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/change_picture.js
diff --git a/chrome/browser/resources/settings/people_page/change_picture.js b/chrome/browser/resources/settings/people_page/change_picture.js
index 5fe931b3e17d7af1aa6931e1980dd019a396f92a..3127373a7654abd7eb6e59a1b28497c8f45f3f12 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.js
+++ b/chrome/browser/resources/settings/people_page/change_picture.js
@@ -2,6 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+cr.define('settings_test', function() {
+ var changePictureOptions = settings_test.changePictureOptions || {
+ /**
+ * True if property changes should fire events for testing purposes.
+ * @type {boolean}
+ */
+ notifyPropertyChangesForTest: false,
+ };
+ return {changePictureOptions: changePictureOptions};
+});
Dan Beam 2016/03/16 17:22:29 why can't this just be cr.exportPath('settings_te
+
/**
* @fileoverview
* 'settings-change-picture' is the settings subpage containing controls to
@@ -22,7 +33,10 @@ Polymer({
* The currently selected profile image URL. May be a data URL.
* @private {string}
*/
- selectedImageUrl_: String,
+ selectedImageUrl_: {
+ type: String,
+ notify: settings_test.changePictureOptions.notifyPropertyChangesForTest,
+ },
/**
* The url of the 'old' image, which is the existing image sourced from

Powered by Google App Engine
This is Rietveld 408576698