chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc - Issue 1585963004: Settings People Revamp: Add tests for ChromeOS Change Picture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

Issue 1585963004: Settings People Revamp: Add tests for ChromeOS Change Picture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/people_page/change_picture.js ('K') | « chrome/browser/resources/settings/people_page/change_picture.js ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

diff --git a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

index 8a523a347cf2d54cf21ecf68ebdab91579552c68..b902894c5c6e71b965a81e7b00200810bc33a0d4 100644

--- a/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

+++ b/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc

@@ -276,7 +276,7 @@ void ChangePictureHandler::HandleSelectImage(const base::ListValue* args) {

NOTREACHED();

return;

}

- DCHECK(!image_url.empty());

+ // |image_url| may be empty unless |image_type| is "default".

DCHECK(!image_type.empty());

UserImageManager* user_image_manager =