Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1585843010: [heap] Make survival counters concurrent (atomic) (Closed)

Created:
4 years, 11 months ago by Michael Lippautz
Modified:
4 years, 11 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Make survival counters concurrent (atomic) Those counters will be incremented concurrently during parallel evacuation of newspace. This change makes sure we do the updates atomically. Note that actual reasoning about them happens sequentially on the main thread. BUG=chromium:524425 LOG=N R=ulan@chromium.org Committed: https://crrev.com/7cf64f4017fdfc8e39afb5ab1940a37fe2e02ca3 Cr-Commit-Position: refs/heads/master@{#33326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -33 lines) Patch
M src/heap/heap.h View 4 chunks +27 lines, -15 lines 0 comments Download
M src/heap/heap.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Lippautz
PTAl, this is the other small spin-off from the parallel evacuation prototype.
4 years, 11 months ago (2016-01-15 11:56:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585843010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585843010/1
4 years, 11 months ago (2016-01-15 11:57:10 UTC) #3
ulan
lgtm
4 years, 11 months ago (2016-01-15 12:01:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 12:19:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585843010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585843010/1
4 years, 11 months ago (2016-01-15 12:20:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 12:23:08 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 12:23:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cf64f4017fdfc8e39afb5ab1940a37fe2e02ca3
Cr-Commit-Position: refs/heads/master@{#33326}

Powered by Google App Engine
This is Rietveld 408576698