Move serviceworker/ module to oilpan

Move serviceworker/ module to oilpan

- This CL doesn't move InstallEvent and InstallPhaseEvent since we need to move Event first.

- This CL doesn't move ServiceWorkerGlobalScope since we need to move WorkerGlobalScope first.

- This CL doesn't move ServiceWorkerThread since we need to move WorkerThread first.

BUG=340522
TBR=abarth (for web/)

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166694

[haraken, 2014-02-07 05:42:27]

PTAL
(cc: kinuko@, alecflett@)

Currently ServiceWorker is actively being developed. So it might not be a good
idea to leave transition types for a long time in the trunk. To keep the trunk
as clean as possible, we might want to land this CL after supporting real types.

(Note: virtual/serviceworker/http/tests/serviceworker/registration.html crashes,
but the crash is not related to this CL. It is happening in trunk as well.)

[Mads Ager (chromium), 2014-02-07 06:50:46]

LGTM

https://codereview.chromium.org/153083006/diff/60001/Source/bindings/v8/Scrip...
File Source/bindings/v8/ScriptPromiseResolver.h (right):

https://codereview.chromium.org/153083006/diff/60001/Source/bindings/v8/Scrip...
Source/bindings/v8/ScriptPromiseResolver.h:99: void resolve(RawPtr<T> value,
v8::Handle<v8::Object> creationContext) { resolve(value.get(), creationContext);
}
Can we fold these together into:

void resolve(PassRefPtrWillBeRawPtr<T> value, ...) { ... }

?

[haraken, 2014-02-07 07:12:39]

On 2014/02/07 06:50:46, Mads Ager (chromium) wrote:
> LGTM
> 
>
https://codereview.chromium.org/153083006/diff/60001/Source/bindings/v8/Scrip...
> File Source/bindings/v8/ScriptPromiseResolver.h (right):
> 
>
https://codereview.chromium.org/153083006/diff/60001/Source/bindings/v8/Scrip...
> Source/bindings/v8/ScriptPromiseResolver.h:99: void resolve(RawPtr<T> value,
> v8::Handle<v8::Object> creationContext) { resolve(value.get(),
creationContext);
> }
> Can we fold these together into:
> 
> void resolve(PassRefPtrWillBeRawPtr<T> value, ...) { ... }
> 
> ?

Unfortunately no, because we need both PassRefPtr version and RawPtr version in
the oilpan build. Once we remove all PassRefPtr users for resolve(), we can
change it to PassRefPtrWillBeRawPtr.

[haraken, 2014-02-07 07:12:43]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-07 07:12:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/153083006/60001

[commit-bot: I haz the power, 2014-02-07 07:38:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-07 07:38:51]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[haraken, 2014-02-07 07:40:09]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-07 07:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/153083006/60001

[tkent, 2014-02-07 07:43:39]

lgtm for web/

[commit-bot: I haz the power, 2014-02-07 08:42:43]

Change committed as 166694

[alecflett, 2014-02-07 19:28:43]

I really wish we could have waited on this - we have a number of CL's in-flight
that will collide with this, and now we need to spend some time learning more
deeply how oilpan works.

[adamk, 2014-02-07 19:45:41]

On 2014/02/07 19:28:43, alecflett wrote:
> I really wish we could have waited on this - we have a number of CL's
in-flight
> that will collide with this, and now we need to spend some time learning more
> deeply how oilpan works.

I'd support reverting this and asking the oilpan folks to choose a different
target, given how quickly ServiceWorker is evolving.

[Mads Ager (chromium), 2014-02-07 20:15:50]

Go ahead and revert if this makes it hard for you guys to make progress. We
can get back to this later when it is moving at a slower pace.

Cheers,    -- Mads


On Fri, Feb 7, 2014 at 8:45 PM, <adamk@chromium.org> wrote:

> On 2014/02/07 19:28:43, alecflett wrote:
>
>> I really wish we could have waited on this - we have a number of CL's
>>
> in-flight
>
>> that will collide with this, and now we need to spend some time learning
>> more
>> deeply how oilpan works.
>>
>
> I'd support reverting this and asking the oilpan folks to choose a
> different
> target, given how quickly ServiceWorker is evolving.
>
> https://codereview.chromium.org/153083006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[haraken, 2014-02-08 01:04:56]

I'm sorry that it caused the trouble in your development. Unfortunately I don't
have a corp access now, so let me revert the CL on Monday or feel free to revert
it anytime.

[haraken, 2014-02-10 01:17:01]

Reverted the CL in r166773.

I'm sorry about the trouble. We'll oilpanize ServiceWorker after your current,
active development is finished.