src/utils/debugger/SkDebugCanvas.cpp - Issue 1585813004: SkValue: SkXfermode - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(87)

My Issues | Starred Open | Closed | All

Unified Diff: src/utils/debugger/SkDebugCanvas.cpp

Issue 1585813004: SkValue: SkXfermode (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: response, also dump Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« src/core/SkXfermode.cpp ('K') | « src/effects/SkPixelXorXfermode.cpp ('k') | tests/ValueTest.cpp » ('j') | tests/ValueTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/utils/debugger/SkDebugCanvas.cpp

diff --git a/src/utils/debugger/SkDebugCanvas.cpp b/src/utils/debugger/SkDebugCanvas.cpp

index 63739aee814a41a1a4b338d6009590f20eec56d8..0f837594ce205de44abf88e0be3373a92ade1e72 100644

--- a/src/utils/debugger/SkDebugCanvas.cpp

+++ b/src/utils/debugger/SkDebugCanvas.cpp

@@ -12,6 +12,7 @@

#include "SkDevice.h"

#include "SkPaintFilterCanvas.h"

#include "SkXfermode.h"

+#include "SkValue.h"

namespace {

@@ -54,6 +55,10 @@ public:

#ifndef SK_IGNORE_TO_STRING

void toString(SkString* str) const override { str->set("OverdrawXfermode"); }

#endif

+

+ SkValue asValue() const override {

+ return SkValue::Object(SkValue::OverdrawXfermode);

+ }

};

mtklein 2016/01/15 00:25:22 Let's not bother with this xfermode. We don't ser

hal.canary 2016/01/15 13:38:56 done

class DebugPaintFilterCanvas : public SkPaintFilterCanvas {

« src/core/SkXfermode.cpp ('K') | « src/effects/SkPixelXorXfermode.cpp ('k') | tests/ValueTest.cpp » ('j') | tests/ValueTest.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698