SkValue: SkXfermode

src/core/SkXfermode.cpp

Index: src/core/SkXfermode.cpp
diff --git a/src/core/SkXfermode.cpp b/src/core/SkXfermode.cpp
index 79de322c2daceb95dce39bfc304776556e5ade70..fe8db6ccee97ff0910737d8e43bfb83437d1ff8d 100644
--- a/src/core/SkXfermode.cpp
+++ b/src/core/SkXfermode.cpp
@@ -15,6 +15,7 @@
 #include "SkReadBuffer.h"
 #include "SkString.h"
 #include "SkWriteBuffer.h"
+#include "SkValue.h"
 
 #define SkAlphaMulAlpha(a, b)   SkMulDiv255Round(a, b)
 
@@ -763,6 +764,14 @@ void SkProcCoeffXfermode::flatten(SkWriteBuffer& buffer) const {
     buffer.write32(fMode);
 }
 
+enum { ProcCoeffXfermode_Mode };

[mtklein, 2016/01/15 00:25:22]

This name does not fit any naming scheme we use in Skia.  Worse, it looks like
it's a member of some Mode enum with value ProcCoeffXfermode.

Why are you complicating this?  Just write kMode.

[hal.canary, 2016/01/15 13:38:56]

done

+
+SkValue SkProcCoeffXfermode::asValue() const {
+    auto value = SkValue::Object(SkValue::ProcCoeffXfermode);
+    value.set(ProcCoeffXfermode_Mode, SkValue::FromU32(SkToU32(fMode)));
+    return value;
+}
+
 bool SkProcCoeffXfermode::asMode(Mode* mode) const {
     if (mode) {
         *mode = fMode;