Issue 15858005: Implement get/set field in library and class mirrors.

Issue 15858005: Implement get/set field in library and class mirrors. (Closed)

Created:
7 years, 7 months ago by ahe

Modified:
7 years, 7 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org, ngeoffray, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement get/set field in library and class mirrors. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23070

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -20 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart	View	7 chunks	+148 lines, -18 lines	2 comments	Download
M	dart/tests/lib/mirrors/mirrors_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r23070 (presubmit successful).

7 years, 7 months ago (2013-05-23 14:24:07 UTC) #3

Johnni Winther

lgtm https://codereview.chromium.org/15858005/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart (right): https://codereview.chromium.org/15858005/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart#newcode253 dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:253: bool readOnly = hasSetter; Shouldn't it be [: ...

7 years, 7 months ago (2013-05-23 20:21:59 UTC) #4

ahe

7 years, 7 months ago (2013-05-24 12:00:13 UTC) #5

Message was sent while issue was closed.

Nice catch!

https://codereview.chromium.org/15858005/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart
(right):

https://codereview.chromium.org/15858005/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:253: bool
readOnly = hasSetter;
On 2013/05/23 20:21:59, Johnni Winther wrote:
> Shouldn't it be [: readOnly = !hasSetter :] ? 

Fixed in CL 15895002.

Expand Messages | Collapse Messages