Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1585793002: Update lifecycle phases when a WebView is resized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index dd06d101a9955c3692e845ea55dbda179ca81dd7..e821c3b4a8c796d86e7933a911e7f8e83a1c85e6 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -4710,10 +4710,10 @@ TEST_P(ParameterizedWebFrameTest, CompositedSelectionBoundsCleared)
webViewHelper.webView()->resize(WebSize(viewWidth, viewHeight));
FrameTestHelpers::loadFrame(webViewHelper.webView()->mainFrame(), m_baseURL + "select_range_basic.html");
- // The frame starts with a non-empty selection.
+ // The frame starts with no selection.
WebFrame* frame = webViewHelper.webView()->mainFrame();
ASSERT_TRUE(frame->hasSelection());
- EXPECT_FALSE(fakeSelectionLayerTreeView.getAndResetSelectionCleared());
chrishtr 2016/01/15 02:17:13 This change is because we are now pumping the whol
+ EXPECT_TRUE(fakeSelectionLayerTreeView.getAndResetSelectionCleared());
// The selection cleared notification should be triggered upon layout.
frame->executeCommand(WebString::fromUTF8("Unselect"));
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698