Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1585793002: Update lifecycle phases when a WebView is resized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 1003da0baa19d8ad7a765dcef8c7f0cb24c73c98..30d37eb148d2eb45eed04007a1f343dbf575a529 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -1902,9 +1902,9 @@ void WebViewImpl::resizeViewWhileAnchored(FrameView* view)
m_fullscreenController->updateSize();
- // Relayout immediately to recalculate the minimum scale limit for rotation anchoring.
- if (view->needsLayout())
- view->layout();
+ // Update lifecyle phases immediately to recalculate the minimum scale limit for rotation anchoring,
+ // and to make sure that no lifecycle states are stale if this WebView is embedded in another one.
+ updateAllLifecyclePhases();
}
void WebViewImpl::resize(const WebSize& newSize)

Powered by Google App Engine
This is Rietveld 408576698