Issue 15857005: Implement newInstance on ClassMirror.

Issue 15857005: Implement newInstance on ClassMirror. (Closed)

Created:
7 years, 7 months ago by ahe

Modified:
7 years, 7 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, ngeoffray, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement newInstance on ClassMirror. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23137

Patch Set 2 : Address review comments #

Patch Set 3 : Rebased #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download
	M	dart/tests/lib/mirrors/mirrors_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

6 out of 10 tests passing in tests/lib/mirrors/mirrors_test.dart.

7 years, 7 months ago (2013-05-23 16:17:10 UTC) #1

kasperl

LGTM! https://codereview.chromium.org/15857005/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart (right): https://codereview.chromium.org/15857005/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart#newcode252 dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:252: return Put new Future<...> on the same line ...

7 years, 7 months ago (2013-05-24 06:50:30 UTC) #2

ahe

Thank you, Kasper! https://codereview.chromium.org/15857005/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart File dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart (right): https://codereview.chromium.org/15857005/diff/1/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart#newcode252 dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart:252: return On 2013/05/24 06:50:30, kasperl wrote: ...

7 years, 7 months ago (2013-05-24 12:04:55 UTC) #3

ahe

7 years, 7 months ago (2013-05-24 12:05:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r23137 (presubmit successful).

Expand Messages | Collapse Messages