Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1585643002: Reenable some AppListService tests. (Closed)

Created:
4 years, 11 months ago by Bernhard Bauer
Modified:
4 years, 11 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, Matt Giuca, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable some AppListService tests. BUG=483615 Committed: https://crrev.com/93ed457a9b64c2a5917826a41482e7141c0907e6 Cr-Commit-Position: refs/heads/master@{#369377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc View 4 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bernhard Bauer
Please review.
4 years, 11 months ago (2016-01-13 11:17:16 UTC) #2
tapted
lgtm (and thanks a ton!) I tried this out locally on Mac ToT as well ...
4 years, 11 months ago (2016-01-14 02:43:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585643002/1
4 years, 11 months ago (2016-01-14 09:15:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 09:19:39 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 09:20:48 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/93ed457a9b64c2a5917826a41482e7141c0907e6
Cr-Commit-Position: refs/heads/master@{#369377}

Powered by Google App Engine
This is Rietveld 408576698