Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc

Issue 1585643002: Reenable some AppListService tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc
diff --git a/chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc b/chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc
index 8639e7140f8360be3320fa910d48689a8ab10d9c..d56fe42da139818a5f14dbb1c6ce8ba577094885 100644
--- a/chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc
+++ b/chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc
@@ -123,12 +123,12 @@ IN_PROC_BROWSER_TEST_F(AppListServiceImplBrowserTest, CreatedLazily) {
}
// Tests that deleting a profile properly clears the app list view delegate, but
-// doesn't destroy it. Disabled on ChromeOS, since profiles can't be deleted
+// doesn't destroy it. Not built on ChromeOS, since profiles can't be deleted
// this way (the second profile isn't signed in, so the test fails when creating
// UserCloudPolicyManagerChromeOS).
-// Disabled because of flakiness: http://crbug.com/483615
+#if !defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(AppListServiceImplBrowserTest,
- DISABLED_DeletingProfileUpdatesViewDelegate) {
+ DeletingProfileUpdatesViewDelegate) {
Profile* second_profile = test::CreateSecondProfileAsync();
service_->ShowForProfile(second_profile);
AppListViewDelegate* view_delegate = test_api_->view_delegate();
@@ -152,6 +152,7 @@ IN_PROC_BROWSER_TEST_F(AppListServiceImplBrowserTest,
EXPECT_EQ(view_delegate, test_api_->view_delegate());
EXPECT_EQ(view_delegate->profile(), browser()->profile());
}
+#endif // !defined(OS_CHROMEOS)
// Test that all the items in the context menu for a hosted app have valid
// labels.
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/app_list_service_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698