Let MakeZip() copy mtimes for toplevel build directory files.

Let MakeZip() copy mtimes for toplevel build directory files.

MakeZip uses shutil.copytree to copy directories, which internally uses
copy2 (which is like copy but copies mtimes, permission bits, and flags too).
Regular files are copied with CopyFileToDir, which up to now only used copy
instead of copy2. Make them consistent.

(Needed for https://codereview.chromium.org/157743004/)

BUG=142642
TBR=maruel@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=250024

[Drew Haven, 2014-02-09 23:36:31]

lgtm

https://codereview.chromium.org/158543002/diff/30001/build/scripts/common/chr...
File build/scripts/common/chromium_utils.py (right):

https://codereview.chromium.org/158543002/diff/30001/build/scripts/common/chr...
build/scripts/common/chromium_utils.py:492: shutil.copy2(src_path,
os.path.join(dest_dir, src_file))
Dunno if maybe we should document that this also copies metadata, as that's not
the usual behavior in a copy on Unix.

[Nico, 2014-02-09 23:41:01]

Thanks!

I looked through the existing callers (
https://code.google.com/p/chromium/codesearch#search/&q=CopyFileToDir&sq=pack...
) and didn't see anything that would be surprised by the slight semantics
change.

https://codereview.chromium.org/158543002/diff/30001/build/scripts/common/chr...
File build/scripts/common/chromium_utils.py (right):

https://codereview.chromium.org/158543002/diff/30001/build/scripts/common/chr...
build/scripts/common/chromium_utils.py:492: shutil.copy2(src_path,
os.path.join(dest_dir, src_file))
On 2014/02/09 23:36:32, Drew Haven wrote:
> Dunno if maybe we should document that this also copies metadata, as that's
not
> the usual behavior in a copy on Unix.

Done.

[Nico, 2014-02-09 23:41:05]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-09 23:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-09 23:41:14]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nico, 2014-02-09 23:42:11]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-09 23:42:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/158543002/80001

[commit-bot: I haz the power, 2014-02-09 23:42:59]

Change committed as 250024

[M-A Ruel, 2014-02-10 15:21:38]

Rubberstamp lgtm.