Let MakeZip() copy mtimes for toplevel build directory files.

build/scripts/common/chromium_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Set of basic operations/utilities that are used by the build. """
 
 from contextlib import contextmanager
 import copy
 import cStringIO
 import errno
@@ skipping 469 matching lines @@
   Raises PathNotFound if either the file or the directory is not found.
   """
   # Verify the file and directory separately so we can tell them apart and
   # raise PathNotFound rather than shutil.copyfile's IOError.
   if not os.path.isfile(src_path):
     raise PathNotFound('Unable to find file %s' % src_path)
   if not os.path.isdir(dest_dir):
     raise PathNotFound('Unable to find dir %s' % dest_dir)
   src_file = os.path.basename(src_path)
   if dest_fn:
-    shutil.copy(src_path, os.path.join(dest_dir, dest_fn))
+    shutil.copy2(src_path, os.path.join(dest_dir, dest_fn))
   else:
-    shutil.copy(src_path, os.path.join(dest_dir, src_file))
+    shutil.copy2(src_path, os.path.join(dest_dir, src_file))

[Drew Haven, 2014/02/09 23:36:32]

Dunno if maybe we should document that this also copies metadata, as that's not
the usual behavior in a copy on Unix.

[Nico, 2014/02/09 23:41:01]

Done.

 
 
 def MakeZip(output_dir, archive_name, file_list, file_relative_dir,
             raise_error=True, remove_archive_directory=True, path_filter=None):
   """Packs files into a new zip archive.
 
   Files are first copied into a directory within the output_dir named for
   the archive_name, which will be created if necessary and emptied if it
   already exists.  The files are then then packed using archive names
   relative to the output_dir.  That is, if the zipfile is unpacked in place,
-  it will create a directory identical to the new archiev_name directory, in
+  it will create a directory identical to the new archive_name directory, in
   the output_dir.  The zip file will be named as the archive_name, plus
   '.zip'.
 
   Args:
     output_dir: Absolute path to the directory in which the archive is to
       be created.
     archive_dir: Subdirectory of output_dir holding files to be added to
       the new zipfile.
     file_list: List of paths to files or subdirectories, relative to the
       file_relative_dir.
@@ skipping 842 matching lines @@
   """
   try:
     pool = multiprocessing.Pool(processes=processes)
     yield pool
     pool.close()
   except:
     pool.terminate()
     raise
   finally:
     pool.join()