Fork a subset of ash/shelf for use in mash.

Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com

Committed: https://crrev.com/16ae0289babd745cf8c54313b42795448c99ebb3
Cr-Commit-Position: refs/heads/master@{#371866}

[msw, 2016-01-22 23:42:46]

Description was changed from

==========
Fork ash/shelf for mash/shelf.

BUG=
==========

to

==========
Fork ash/shelf for mash/shelf.

BUG=557406
==========

[msw, 2016-01-26 21:34:51]

Description was changed from

==========
Fork ash/shelf for mash/shelf.

BUG=557406
==========

to

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org
==========

[msw, 2016-01-26 21:34:52]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-01-26 21:39:37]

Patchset #12 (id:220001) has been deleted

[msw, 2016-01-26 21:45:25]

Hey Scott, please take a look; thanks!
Changes to ash/ are just for diffing, they'll be revered.

I can remove more commented/unused code, but it'll just be slightly tougher to
restore it (+review?) when I get those features working again. I could also
continue restoring features before landing this (overflow/drag might be next?),
but I figure it's in a decent place to land some incremental progress.

[msw, 2016-01-27 03:51:51]

Patchset #15 (id:300001) has been deleted

[msw, 2016-01-27 03:51:59]

Patchset #14 (id:280001) has been deleted

[msw, 2016-01-27 03:52:10]

Patchset #13 (id:260001) has been deleted

[msw, 2016-01-27 04:08:49]

Hey Scott, please take a look now; thanks! The latest patch set restores
additional code (commented out), adds TODOs, and reduces the diff overall. See
the second to last patch set for diffing to ash/shelf.

[msw, 2016-01-27 04:57:28]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 04:57:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585363002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585363002/340001

[commit-bot: I haz the power, 2016-01-27 05:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 05:05:18]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[msw, 2016-01-27 07:43:42]

some self review comments...

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_appli...
File mash/shelf/shelf_application.cc (right):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_appli...
mash/shelf/shelf_application.cc:43: widget->SetContentsView(new ShelfView(app));
Add a note and file a bug.

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_butto...
File mash/shelf/shelf_button.cc (right):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_butto...
mash/shelf/shelf_button.cc:533: // TODO(msw): Restore shelf button bar images.
Standardize commenting.

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_item_...
File mash/shelf/shelf_item_types.h (right):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_item_...
mash/shelf/shelf_item_types.h:76: // TODO(msw): Support multiple open windows
per button.
comment

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_item_...
mash/shelf/shelf_item_types.h:80: // TODO(msw): int image_resource_id;
comment

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_model.h
File mash/shelf/shelf_model.h (right):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_model...
mash/shelf/shelf_model.h:89: // TODO(msw): Do not expose this (used by ShelfView
to FocusUserWindow)...
comment

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_toolt...
File mash/shelf/shelf_tooltip_manager.cc (left):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_toolt...
mash/shelf/shelf_tooltip_manager.cc:297: void
ShelfTooltipManager::WillDeleteShelf() {
Add a comment to restore.

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_toolt...
File mash/shelf/shelf_tooltip_manager.cc (right):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_toolt...
mash/shelf/shelf_tooltip_manager.cc:275: void
ShelfTooltipManager::OnTouchEvent(ui::TouchEvent* event) {
this probably doesn't work... (not watching all touches outside of bubble?)
is this needed, or will the bubble activate & close on loss of activation?

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_toolt...
File mash/shelf/shelf_tooltip_manager.h (left):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_toolt...
mash/shelf/shelf_tooltip_manager.h:86: // ShelfLayoutManagerObserver overrides:
Add a comment to restore...

[sky, 2016-01-27 17:56:37]

LGTM

[msw, 2016-01-27 19:38:46]

Description was changed from

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org
==========

to

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org
TBR=bungeman@google.com
==========

[msw, 2016-01-27 19:38:46]

msw@chromium.org changed reviewers:
+ bungeman@google.com

[msw, 2016-01-27 19:43:14]

+TBR Ben for mash/shelf dependency on skia.

[msw, 2016-01-27 19:54:09]

The CQ bit was checked by msw@chromium.org

[msw, 2016-01-27 19:54:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1585363002/#ps360001
(title: "Address self-review comments and missing ui/accessibility dep.")

[commit-bot: I haz the power, 2016-01-27 19:55:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585363002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585363002/360001

[bungeman-skia, 2016-01-27 19:59:48]

lgtm, always good to see someone using Skia.

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_view.cc
File mash/shelf/shelf_view.cc (left):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_view....
mash/shelf/shelf_view.cc:38: canvas->FillRect(GetLocalBounds(), SK_ColorYELLOW);
Was already implicitly using a Skia header here?

[commit-bot: I haz the power, 2016-01-27 20:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 20:06:41]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[msw, 2016-01-27 20:21:12]

Patchset #16 (id:380001) has been deleted

[msw, 2016-01-27 20:21:50]

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_view.cc
File mash/shelf/shelf_view.cc (left):

https://codereview.chromium.org/1585363002/diff/340001/mash/shelf/shelf_view....
mash/shelf/shelf_view.cc:38: canvas->FillRect(GetLocalBounds(), SK_ColorYELLOW);
On 2016/01/27 19:59:48, bungeman1 wrote:
> Was already implicitly using a Skia header here?

Yup! Looks like it's a public deps of ui/gfx, and transitive includes allowed
use of this color constant with an explicit include or DEPS addition.

[msw, 2016-01-27 20:22:07]

Description was changed from

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org
TBR=bungeman@google.com
==========

to

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com
==========

[msw, 2016-01-27 20:22:20]

The CQ bit was checked by msw@chromium.org

[msw, 2016-01-27 20:22:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1585363002/#ps400001
(title: "Add ui/resources dep; comment out unused constants.")

[commit-bot: I haz the power, 2016-01-27 20:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1585363002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1585363002/400001

[commit-bot: I haz the power, 2016-01-27 21:07:21]

Description was changed from

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com
==========

to

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com
==========

[commit-bot: I haz the power, 2016-01-27 21:07:22]

Committed patchset #16 (id:400001)

[commit-bot: I haz the power, 2016-01-27 21:09:47]

Description was changed from

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com
==========

to

==========
Fork a subset of ash/shelf for use in mash.

Fork Shelf View, Model, Button, TooltipManager, etc.
These provide a baseline of ash/shelf-like functionality.
(show open mash windows, support reordering, tooltips, etc.)

Restructure some ownership patterns (eg. shelf owns model).
Minimal code refactoring, removal and commenting.
(attempt to minimize diff, keep/stub some features)

TODO: Restore missing functionality/tests.

BUG=557406
TEST=mojo:mash_shell's shelf starts looking more like ash.
R=sky@chromium.org,bungeman@google.com

Committed: https://crrev.com/16ae0289babd745cf8c54313b42795448c99ebb3
Cr-Commit-Position: refs/heads/master@{#371866}
==========

[commit-bot: I haz the power, 2016-01-27 21:09:48]

Patchset 16 (id:??) landed as
https://crrev.com/16ae0289babd745cf8c54313b42795448c99ebb3
Cr-Commit-Position: refs/heads/master@{#371866}