Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1585233004: Merge to XFA: Fix the way FT headers are included (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix the way FT headers are included FreeType headers have to be included with macros defined in ftheaders.h. Not doing so breaks when the FreeType header location changes as was the case between FreeType 2.6.0 and 2.6.2. Patch by jshin@chromium.org BUG=pdfium:362 TBR=jshin@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1587333002 . (cherry picked from commit 56461d66054c53fe3abc88208eaf5d84e80e6551) Committed: https://pdfium.googlesource.com/pdfium/+/6eaaaa3ed4157df021e99146422fd8634c63ecd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M core/include/fxge/fx_freetype.h View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Lei Zhang
TBR
4 years, 11 months ago (2016-01-15 23:31:09 UTC) #1
Lei Zhang
4 years, 11 months ago (2016-01-15 23:31:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6eaaaa3ed4157df021e99146422fd8634c63ecd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698