Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1587333002: Fix the way FT headers are included (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the way FT headers are included FreeType headers have to be included with macros defined in ftheaders.h. Not doing so breaks when the FreeType header location changes as was the case between FreeType 2.6.0 and 2.6.2. Patch by jshin@chromium.org BUG=pdfium:362 R=jshin@chromium.org, tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/56461d66054c53fe3abc88208eaf5d84e80e6551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M core/include/fxge/fx_freetype.h View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-14 23:05:04 UTC) #2
jungshik at Google
Thanks a lot, Lei. LGTM
4 years, 11 months ago (2016-01-14 23:19:19 UTC) #3
Tom Sepez
Stampy Stamp LGTM
4 years, 11 months ago (2016-01-15 23:17:59 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-15 23:23:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56461d66054c53fe3abc88208eaf5d84e80e6551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698