Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1585213005: forward incremental resolver exceptions to analysis engine log (Closed)

Created:
4 years, 11 months ago by skybrian
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

forward incremental resolver exceptions to analysis engine log BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/4d3d65b806d2c260c9d5a7f0acafdf32435b6cc7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
skybrian
4 years, 11 months ago (2016-01-14 21:30:47 UTC) #2
Brian Wilkerson
I'll defer to Konstantin because I don't know what the original reason was for having ...
4 years, 11 months ago (2016-01-14 21:45:14 UTC) #3
scheglov
lgtm https://codereview.chromium.org/1585213005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/1585213005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1563 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1563: 'failure in incremental resolver', new CaughtException(e, st)); Please ...
4 years, 11 months ago (2016-01-14 21:55:14 UTC) #4
skybrian
https://codereview.chromium.org/1585213005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/1585213005/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode1563 pkg/analyzer/lib/src/generated/incremental_resolver.dart:1563: 'failure in incremental resolver', new CaughtException(e, st)); On 2016/01/14 ...
4 years, 11 months ago (2016-01-14 22:43:43 UTC) #5
skybrian
4 years, 11 months ago (2016-01-14 23:20:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d3d65b806d2c260c9d5a7f0acafdf32435b6cc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698