forward incremental resolver exceptions to analysis engine log

pkg/analyzer/lib/src/generated/incremental_resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.incremental_resolver;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'package:analyzer/dart/element/element.dart';
@@ skipping 1539 matching lines @@
           return false;
         }
         // update DartEntry
         _updateEntry();
         logger.log('Success.');
         return true;
       }
     } catch (e, st) {
       logger.logException(e, st);
       logger.log('Failure: exception.');
+      // The incremental resolver log is usually turned off,
+      // so also log the exception to the instrumentation log.
+      AnalysisEngine.instance.logger.logError(
+          'failure in incremental resolver', new CaughtException(e, st));

[scheglov, 2016/01/14 21:55:14]

Please capitalize the message: 'Failure in incremental resolver'.

[skybrian, 2016/01/14 22:43:43]

Done.

     } finally {
       logger.exit();
     }
     return false;
   }
 
   CompilationUnit _parseUnit(String code) {
     LoggingTimer timer = logger.startTimer();
     try {
       Token token = _scan(code);
@@ skipping 531 matching lines @@
   @override
   String toString() => name;
 }
 
 class _TokenPair {
   final _TokenDifferenceKind kind;
   final Token oldToken;
   final Token newToken;
   _TokenPair(this.kind, this.oldToken, this.newToken);
 }