Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1585183002: [Interpreter] [arm] Fix PushArgsAndConstruct (Closed)

Created:
4 years, 11 months ago by Jakob Kummerow
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] [arm] Fix PushArgsAndConstruct When reserving a stack slot for the receiver, push an Immediate(0) rather than a register that contains an untagged integer. All other platforms push zero already. Committed: https://crrev.com/48a3227b7dd2f285aa599eb1cdf5f8bc94acdec7 Cr-Commit-Position: refs/heads/master@{#33299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL. As discussed, this hopefully fixes some of the tests that are currently marked as ...
4 years, 11 months ago (2016-01-14 14:08:21 UTC) #2
rmcilroy
LGTM, thanks for the fix! I'll run mjsunit locally with / without this patch and ...
4 years, 11 months ago (2016-01-14 14:13:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585183002/1
4 years, 11 months ago (2016-01-14 14:47:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 15:08:55 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 15:09:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a3227b7dd2f285aa599eb1cdf5f8bc94acdec7
Cr-Commit-Position: refs/heads/master@{#33299}

Powered by Google App Engine
This is Rietveld 408576698