src/arm/builtins-arm.cc - Issue 1585183002: [Interpreter] [arm] Fix PushArgsAndConstruct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/builtins-arm.cc

Issue 1585183002: [Interpreter] [arm] Fix PushArgsAndConstruct (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/builtins-arm.cc

diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc

index 2490accb69b56b3c37f437a8d3fa14fe86133142..0c83f918caa58e45075e2a1b8e384e7dc41810cf 100644

--- a/src/arm/builtins-arm.cc

+++ b/src/arm/builtins-arm.cc

@@ -1028,7 +1028,8 @@ void Builtins::Generate_InterpreterPushArgsAndConstruct(MacroAssembler* masm) {

__ sub(r4, r2, r4);

// Push a slot for the receiver to be constructed.

- __ push(r0);

+ __ mov(ip, Operand::Zero());

+ __ push(ip);

// Push the arguments.

Generate_InterpreterPushArgs(masm, r2, r4, r5);

« no previous file with comments | « no previous file | no next file » | no next file with comments »