Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 1584993002: Delete code involving overdraw bottom height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete more mCachedVisibleViewport lines Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
index 56acc0eb0aed5a6c718108c42960ce7261013e6e..a9be5fd7d464b000bb46f852783ffab0f1823e32 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
@@ -91,8 +91,6 @@ public class CompositorViewHolder extends FrameLayout
new ArrayList<Invalidator.Client>();
private boolean mSkipInvalidation = false;
- private boolean mSkipNextToolbarTextureUpdate = false;
-
/**
* A task to be performed after a resize event.
*/
@@ -422,23 +420,6 @@ public class CompositorViewHolder extends FrameLayout
sCachedCVCList.clear();
}
- @Override
- public void onOverdrawBottomHeightChanged(int overdrawHeight) {
- mSkipNextToolbarTextureUpdate = true;
- requestRender();
- }
-
- @Override
- public int getCurrentOverdrawBottomHeight() {
- if (mTabVisible != null) {
- float overdrawBottomHeight = mTabVisible.getFullscreenOverdrawBottomHeightPix();
- if (!Float.isNaN(overdrawBottomHeight)) {
- return (int) overdrawBottomHeight;
- }
- }
- return mCompositorView.getOverdrawBottomHeight();
- }
-
/**
* Called whenever the host activity is started.
*/
@@ -533,19 +514,11 @@ public class CompositorViewHolder extends FrameLayout
assert mProgressBarDrawingInfo == null;
}
- mCompositorView.finalizeLayers(mLayoutManager, mSkipNextToolbarTextureUpdate,
+ mCompositorView.finalizeLayers(mLayoutManager, false,
mProgressBarDrawingInfo);
-
- // TODO(changwan): Check if this hack can be removed.
- // This is a hack to draw one more frame if the screen just rotated for Nexus 10 + L.
- // See http://crbug/440469 for more.
- if (mSkipNextToolbarTextureUpdate) {
- requestRender();
- }
}
TraceEvent.end("CompositorViewHolder:layout");
- mSkipNextToolbarTextureUpdate = false;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698