Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3244)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java

Issue 1584993002: Delete code involving overdraw bottom height. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete more mCachedVisibleViewport lines Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
index 3d0f4d85436aacfd275d5e7eedb73d71ed1bae2c..6a22e52302a7318b1648bb34d3a1c2ac711068be 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java
@@ -147,7 +147,6 @@ public class CompositorView
@Override
protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
super.onLayout(changed, left, top, right, bottom);
- mRenderHost.onOverdrawBottomHeightChanged(getOverdrawBottomHeight());
}
@Override
@@ -164,21 +163,6 @@ public class CompositorView
}
/**
- * @return The amount the surface view is overdrawing the window bounds.
- */
- public int getOverdrawBottomHeight() {
- if (mRootActivityView == null) {
- mRootActivityView = mRootView.findViewById(android.R.id.content);
- }
- if (mRootActivityView != null) {
- int compositorHeight = getHeight();
- int rootViewHeight = mRootActivityView.getHeight();
- return Math.max(0, compositorHeight - rootViewHeight);
- }
- return 0;
- }
-
- /**
* Should be called for cleanup when the CompositorView instance is no longer used.
*/
public void shutDown() {
@@ -412,11 +396,7 @@ public class CompositorView
provider.getViewportPixel(mCacheViewport);
nativeSetLayoutViewport(mNativeCompositorView, mCacheViewport.left, mCacheViewport.top,
mCacheViewport.width(), mCacheViewport.height(), mCacheVisibleViewport.left,
- mCacheVisibleViewport.top, mRenderHost.getCurrentOverdrawBottomHeight(), 1.0f);
-
- mCacheVisibleViewport.right = mCacheVisibleViewport.left + mSurfaceWidth;
- mCacheVisibleViewport.bottom = mCacheVisibleViewport.top
- + Math.max(mSurfaceHeight - mRenderHost.getCurrentOverdrawBottomHeight(), 0);
+ mCacheVisibleViewport.top, 1.0f);
// TODO(changwan): move to treeprovider.
updateToolbarLayer(provider, forRotation, progressBarDrawingInfo);
@@ -464,7 +444,7 @@ public class CompositorView
private native void nativeSetNeedsComposite(long nativeCompositorView);
private native void nativeSetLayoutViewport(long nativeCompositorView, float x, float y,
float width, float height, float visibleXOffset, float visibleYOffset,
- float overdrawBottomHeight, float dpToPixel);
+ float dpToPixel);
private native void nativeUpdateToolbarLayer(long nativeCompositorView, int resourceId,
int toolbarBackgroundColor, int urlBarResourceId, float urlBarAlpha, float topOffset,
float brightness, boolean visible, boolean showShadow);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698