Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1584933003: Configure WebView metrics client log source (Closed)

Created:
4 years, 11 months ago by paulmiller
Modified:
4 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Configure WebView metrics client log source ...now that we have the new ANDROID_WEBVIEW log on the server side. BUG=546754 Committed: https://crrev.com/20f73fa98b72f40a5731cb19fdb754e470741bdf Cr-Commit-Position: refs/heads/master@{#369566}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M android_webview/browser/aw_metrics_service_client.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M components/metrics/proto/chrome_user_metrics_extension.proto View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
paulmiller
On 2016/01/13 22:29:55, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:asvitkine@chromium.org, mailto:sgurun@chromium.org PTAL. See ...
4 years, 11 months ago (2016-01-13 22:31:40 UTC) #3
Alexei Svitkine (slow)
lgtm % comment https://codereview.chromium.org/1584933003/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto File components/metrics/proto/chrome_user_metrics_extension.proto (right): https://codereview.chromium.org/1584933003/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto#newcode30 components/metrics/proto/chrome_user_metrics_extension.proto:30: ANDROID_WEBVIEW = 20; Nit: Add a ...
4 years, 11 months ago (2016-01-13 22:37:27 UTC) #4
paulmiller
https://codereview.chromium.org/1584933003/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto File components/metrics/proto/chrome_user_metrics_extension.proto (right): https://codereview.chromium.org/1584933003/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto#newcode30 components/metrics/proto/chrome_user_metrics_extension.proto:30: ANDROID_WEBVIEW = 20; On 2016/01/13 22:37:27, Alexei Svitkine wrote: ...
4 years, 11 months ago (2016-01-13 22:44:08 UTC) #5
sgurun-gerrit only
On 2016/01/13 22:44:08, paulmiller wrote: > https://codereview.chromium.org/1584933003/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto > File components/metrics/proto/chrome_user_metrics_extension.proto (right): > > https://codereview.chromium.org/1584933003/diff/1/components/metrics/proto/chrome_user_metrics_extension.proto#newcode30 > ...
4 years, 11 months ago (2016-01-14 00:06:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584933003/20001
4 years, 11 months ago (2016-01-14 18:19:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/154402)
4 years, 11 months ago (2016-01-14 19:21:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584933003/20001
4 years, 11 months ago (2016-01-14 21:35:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 22:10:52 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 22:12:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20f73fa98b72f40a5731cb19fdb754e470741bdf
Cr-Commit-Position: refs/heads/master@{#369566}

Powered by Google App Engine
This is Rietveld 408576698