Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 1584933003: Configure WebView metrics client log source (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/metrics/proto/chrome_user_metrics_extension.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_metrics_service_client.cc
diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc
index db921c2646be5958bfc95f41e66bb33116ecc969..b360ae9ce5c3c5f8bb64faf3c4c049b369d00b20 100644
--- a/android_webview/browser/aw_metrics_service_client.cc
+++ b/android_webview/browser/aw_metrics_service_client.cc
@@ -165,9 +165,7 @@ bool AwMetricsServiceClient::IsOffTheRecordSessionActive() {
}
int32_t AwMetricsServiceClient::GetProduct() {
- // TODO(paulmiller) Switch this to a WebView product once we have a log source
- // for WebView.
- return ::metrics::ChromeUserMetricsExtension::CHROME;
+ return ::metrics::ChromeUserMetricsExtension::ANDROID_WEBVIEW;
}
std::string AwMetricsServiceClient::GetApplicationLocale() {
@@ -206,9 +204,8 @@ scoped_ptr<metrics::MetricsLogUploader> AwMetricsServiceClient::CreateUploader(
return scoped_ptr<::metrics::MetricsLogUploader>(
new metrics::NetMetricsLogUploader(
request_context_,
- // TODO(paulmiller): Switch this to metrics::kDefaultMetricsServerUrl
- // once we have a log source for WebView.
- "http://localhost:10000/uma/v2", metrics::kDefaultMetricsMimeType,
+ metrics::kDefaultMetricsServerUrl,
+ metrics::kDefaultMetricsMimeType,
on_upload_complete));
}
« no previous file with comments | « no previous file | components/metrics/proto/chrome_user_metrics_extension.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698