Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 158483003: Logically revert r206996, which is no longer used in the era of Aura (Closed)

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
Yuki
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Logically revert r206996, which is no longer used in the era of Aura ui::GetSharedInputMethod() is originally introduced as a tentative solution until Aura transition is completed on Windows. Now we can safely revert that change. BUG=330735, 319122 TEST=covered by unit test because this is dead code removal Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250020

Patch Set 1 #

Patch Set 2 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M ui/base/ime/input_method_factory.h View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 1 2 chunks +0 lines, -21 lines 0 comments Download
M ui/base/ime/input_method_initializer.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yukawa
Hi, This is another dead code removal. Could you take a look?
6 years, 10 months ago (2014-02-09 16:23:04 UTC) #1
Yuki
lgtm
6 years, 10 months ago (2014-02-09 16:32:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/158483003/1
6 years, 10 months ago (2014-02-09 16:32:48 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-09 16:56:43 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=226726
6 years, 10 months ago (2014-02-09 16:56:44 UTC) #5
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-09 17:21:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/158483003/260001
6 years, 10 months ago (2014-02-09 17:21:33 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-09 22:58:48 UTC) #8
Message was sent while issue was closed.
Change committed as 250020

Powered by Google App Engine
This is Rietveld 408576698