 Chromium Code Reviews
 Chromium Code Reviews Issue 1584813002:
  [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@int_forin
    
  
    Issue 1584813002:
  [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@int_forin| Index: src/interpreter/bytecode-array-builder.h | 
| diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h | 
| index 6e2096ceba8450a566d2232b621796da67b174fd..a7cf78417a741eb8cd124783c682042580e00a4c 100644 | 
| --- a/src/interpreter/bytecode-array-builder.h | 
| +++ b/src/interpreter/bytecode-array-builder.h | 
| @@ -221,11 +221,10 @@ class BytecodeArrayBuilder final { | 
| BytecodeArrayBuilder& Return(); | 
| // Complex flow control. | 
| - BytecodeArrayBuilder& ForInPrepare(Register cache_type, Register cache_array, | 
| - Register cache_length); | 
| + BytecodeArrayBuilder& ForInPrepare(Register first_register); | 
| BytecodeArrayBuilder& ForInDone(Register index, Register cache_length); | 
| - BytecodeArrayBuilder& ForInNext(Register receiver, Register cache_type, | 
| - Register cache_array, Register index); | 
| + BytecodeArrayBuilder& ForInNext(Register receiver, Register index, | 
| + Register cache_register_pair); | 
| 
oth
2016/01/13 15:28:58
The name of the third argument differs in the .cc
 
rmcilroy
2016/01/18 09:40:49
Good idea, done.
 | 
| BytecodeArrayBuilder& ForInStep(Register index); | 
| // Accessors |