src/compiler/interpreter-assembler.cc - Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/interpreter-assembler.cc

Issue 1584813002: [Interpreter] Make ForInPrepare take a kRegTriple8 and ForInNext take kRegPair8 for cache state (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_forin

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/interpreter-assembler.cc

diff --git a/src/compiler/interpreter-assembler.cc b/src/compiler/interpreter-assembler.cc

index 7080d02120903237aa2803db368440e4429d6ebc..653434754244cd7075f81d9dd308b9c2368242d5 100644

--- a/src/compiler/interpreter-assembler.cc

+++ b/src/compiler/interpreter-assembler.cc

@@ -304,6 +304,7 @@ Node* InterpreterAssembler::BytecodeOperandReg(int operand_index) {

switch (interpreter::Bytecodes::GetOperandType(bytecode_, operand_index)) {

case interpreter::OperandType::kReg8:

case interpreter::OperandType::kRegPair8:

+ case interpreter::OperandType::kRegTriple8:

case interpreter::OperandType::kMaybeReg8:

DCHECK_EQ(

interpreter::OperandSize::kByte,

« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | src/interpreter/bytecode-array-builder.h » ('J')