Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 15848009: Revert 203025 "Make the copy of GURL in src/url buildable as a c..." (Closed)

Created:
7 years, 6 months ago by Lei Zhang
Modified:
7 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 203025 "Make the copy of GURL in src/url buildable as a c..." > Make the copy of GURL in src/url buildable as a component build. (try 2) > > BUG=229660 > TBR=brettw > > Review URL: https://chromiumcodereview.appspot.com/15805003 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -440 lines) Patch
M trunk/src/url/gurl.h View 3 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/url/url.gyp View 4 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/url/url_canon.h View 16 chunks +241 lines, -246 lines 0 comments Download
M trunk/src/url/url_canon_icu.h View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/url/url_canon_internal.h View 5 chunks +12 lines, -13 lines 0 comments Download
M trunk/src/url/url_canon_ip.h View 4 chunks +18 lines, -19 lines 0 comments Download
D trunk/src/url/url_export.h View 1 chunk +0 lines, -33 lines 0 comments Download
M trunk/src/url/url_parse.h View 8 chunks +48 lines, -56 lines 0 comments Download
M trunk/src/url/url_util.h View 10 chunks +58 lines, -59 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
7 years, 6 months ago (2013-05-30 00:45:39 UTC) #1
Lei Zhang
7 years, 6 months ago (2013-05-30 00:45:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r203027.

Powered by Google App Engine
This is Rietveld 408576698