Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: trunk/src/url/url_canon_ip.h

Issue 15848009: Revert 203025 "Make the copy of GURL in src/url buildable as a c..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/url/url_canon_internal.h ('k') | trunk/src/url/url_export.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/url/url_canon_ip.h
===================================================================
--- trunk/src/url/url_canon_ip.h (revision 203026)
+++ trunk/src/url/url_canon_ip.h (working copy)
@@ -7,18 +7,17 @@
#include "base/string16.h"
#include "url/url_canon.h"
-#include "url/url_export.h"
#include "url/url_parse.h"
namespace url_canon {
// Writes the given IPv4 address to |output|.
-URL_EXPORT void AppendIPv4Address(const unsigned char address[4],
- CanonOutput* output);
+void AppendIPv4Address(const unsigned char address[4],
+ CanonOutput* output);
// Writes the given IPv6 address to |output|.
-URL_EXPORT void AppendIPv6Address(const unsigned char address[16],
- CanonOutput* output);
+void AppendIPv6Address(const unsigned char address[16],
+ CanonOutput* output);
// Searches the host name for the portions of the IPv4 address. On success,
// each component will be placed into |components| and it will return true.
@@ -38,12 +37,12 @@
// Mozilla), so this code path never gets hit. Our host canonicalization will
// notice these spaces and escape them, which will make IP address finding
// fail. This seems like better behavior than stripping after a space.
-URL_EXPORT bool FindIPv4Components(const char* spec,
- const url_parse::Component& host,
- url_parse::Component components[4]);
-URL_EXPORT bool FindIPv4Components(const char16* spec,
- const url_parse::Component& host,
- url_parse::Component components[4]);
+bool FindIPv4Components(const char* spec,
+ const url_parse::Component& host,
+ url_parse::Component components[4]);
+bool FindIPv4Components(const char16* spec,
+ const url_parse::Component& host,
+ url_parse::Component components[4]);
// Converts an IPv4 address to a 32-bit number (network byte order).
//
@@ -56,12 +55,12 @@
//
// On success, |num_ipv4_components| will be populated with the number of
// components in the IPv4 address.
-URL_EXPORT CanonHostInfo::Family IPv4AddressToNumber(
+CanonHostInfo::Family IPv4AddressToNumber(
const char* spec,
const url_parse::Component& host,
unsigned char address[4],
int* num_ipv4_components);
-URL_EXPORT CanonHostInfo::Family IPv4AddressToNumber(
+CanonHostInfo::Family IPv4AddressToNumber(
const char16* spec,
const url_parse::Component& host,
unsigned char address[4],
@@ -72,12 +71,12 @@
//
// NOTE that |host| is expected to be surrounded by square brackets.
// i.e. "[::1]" rather than "::1".
-URL_EXPORT bool IPv6AddressToNumber(const char* spec,
- const url_parse::Component& host,
- unsigned char address[16]);
-URL_EXPORT bool IPv6AddressToNumber(const char16* spec,
- const url_parse::Component& host,
- unsigned char address[16]);
+bool IPv6AddressToNumber(const char* spec,
+ const url_parse::Component& host,
+ unsigned char address[16]);
+bool IPv6AddressToNumber(const char16* spec,
+ const url_parse::Component& host,
+ unsigned char address[16]);
} // namespace url_canon
« no previous file with comments | « trunk/src/url/url_canon_internal.h ('k') | trunk/src/url/url_export.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698