Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: components/omnibox/browser/omnibox_field_trial_unittest.cc

Issue 1584733003: [Cleanup] Remove some expired omnibox field trials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a unit test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.cc ('k') | ios/chrome/browser/ios_chrome_field_trials.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/omnibox_field_trial_unittest.cc
diff --git a/components/omnibox/browser/omnibox_field_trial_unittest.cc b/components/omnibox/browser/omnibox_field_trial_unittest.cc
index 77f903d26995e44b0c1462f67d64a4fffd70ccd2..1dc727af432945f6e2a189441ba30717fc6a9230 100644
--- a/components/omnibox/browser/omnibox_field_trial_unittest.cc
+++ b/components/omnibox/browser/omnibox_field_trial_unittest.cc
@@ -31,7 +31,6 @@ class OmniboxFieldTrialTest : public testing::Test {
field_trial_list_.reset(new base::FieldTrialList(
new metrics::SHA1EntropyProvider("foo")));
variations::testing::ClearAllVariationParams();
- OmniboxFieldTrial::ActivateDynamicTrials();
}
// Creates and activates a field trial.
@@ -139,12 +138,6 @@ TEST_F(OmniboxFieldTrialTest, GetDisabledProviderTypes) {
EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes());
{
- SCOPED_TRACE("Outside the bundled field trial.");
- CreateTestTrial("AutocompleteDynamicTrial_0", "DisabledProviders_123");
- EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes());
- }
-
- {
SCOPED_TRACE("Valid field trial, missing param.");
ResetFieldTrialList();
std::map<std::string, std::string> params;
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.cc ('k') | ios/chrome/browser/ios_chrome_field_trials.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698