OLD | NEW |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "components/omnibox/browser/omnibox_field_trial.h" | 5 #include "components/omnibox/browser/omnibox_field_trial.h" |
6 | 6 |
7 #include "base/command_line.h" | 7 #include "base/command_line.h" |
8 #include "base/macros.h" | 8 #include "base/macros.h" |
9 #include "base/memory/scoped_ptr.h" | 9 #include "base/memory/scoped_ptr.h" |
10 #include "base/metrics/field_trial.h" | 10 #include "base/metrics/field_trial.h" |
(...skipping 13 matching lines...) Expand all Loading... |
24 ResetFieldTrialList(); | 24 ResetFieldTrialList(); |
25 } | 25 } |
26 | 26 |
27 void ResetFieldTrialList() { | 27 void ResetFieldTrialList() { |
28 // Destroy the existing FieldTrialList before creating a new one to avoid | 28 // Destroy the existing FieldTrialList before creating a new one to avoid |
29 // a DCHECK. | 29 // a DCHECK. |
30 field_trial_list_.reset(); | 30 field_trial_list_.reset(); |
31 field_trial_list_.reset(new base::FieldTrialList( | 31 field_trial_list_.reset(new base::FieldTrialList( |
32 new metrics::SHA1EntropyProvider("foo"))); | 32 new metrics::SHA1EntropyProvider("foo"))); |
33 variations::testing::ClearAllVariationParams(); | 33 variations::testing::ClearAllVariationParams(); |
34 OmniboxFieldTrial::ActivateDynamicTrials(); | |
35 } | 34 } |
36 | 35 |
37 // Creates and activates a field trial. | 36 // Creates and activates a field trial. |
38 static base::FieldTrial* CreateTestTrial(const std::string& name, | 37 static base::FieldTrial* CreateTestTrial(const std::string& name, |
39 const std::string& group_name) { | 38 const std::string& group_name) { |
40 base::FieldTrial* trial = base::FieldTrialList::CreateFieldTrial( | 39 base::FieldTrial* trial = base::FieldTrialList::CreateFieldTrial( |
41 name, group_name); | 40 name, group_name); |
42 trial->group(); | 41 trial->group(); |
43 return trial; | 42 return trial; |
44 } | 43 } |
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
132 EXPECT_EQ(expected_from_last_keystroke, from_last_keystroke); | 131 EXPECT_EQ(expected_from_last_keystroke, from_last_keystroke); |
133 EXPECT_EQ(expected_delay_ms, delay_ms); | 132 EXPECT_EQ(expected_delay_ms, delay_ms); |
134 } | 133 } |
135 | 134 |
136 // Test if GetDisabledProviderTypes() properly parses various field trial | 135 // Test if GetDisabledProviderTypes() properly parses various field trial |
137 // group names. | 136 // group names. |
138 TEST_F(OmniboxFieldTrialTest, GetDisabledProviderTypes) { | 137 TEST_F(OmniboxFieldTrialTest, GetDisabledProviderTypes) { |
139 EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes()); | 138 EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes()); |
140 | 139 |
141 { | 140 { |
142 SCOPED_TRACE("Outside the bundled field trial."); | |
143 CreateTestTrial("AutocompleteDynamicTrial_0", "DisabledProviders_123"); | |
144 EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes()); | |
145 } | |
146 | |
147 { | |
148 SCOPED_TRACE("Valid field trial, missing param."); | 141 SCOPED_TRACE("Valid field trial, missing param."); |
149 ResetFieldTrialList(); | 142 ResetFieldTrialList(); |
150 std::map<std::string, std::string> params; | 143 std::map<std::string, std::string> params; |
151 ASSERT_TRUE(variations::AssociateVariationParams( | 144 ASSERT_TRUE(variations::AssociateVariationParams( |
152 OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A", params)); | 145 OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A", params)); |
153 base::FieldTrialList::CreateFieldTrial( | 146 base::FieldTrialList::CreateFieldTrial( |
154 OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A"); | 147 OmniboxFieldTrial::kBundledExperimentFieldTrialName, "A"); |
155 EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes()); | 148 EXPECT_EQ(0, OmniboxFieldTrial::GetDisabledProviderTypes()); |
156 } | 149 } |
157 | 150 |
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
515 NULL, NULL, false, | 508 NULL, NULL, false, |
516 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs); | 509 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs); |
517 | 510 |
518 // Valid params. | 511 // Valid params. |
519 VerifySuggestPollingStrategy("true", "50", true, 50); | 512 VerifySuggestPollingStrategy("true", "50", true, 50); |
520 VerifySuggestPollingStrategy(NULL, "35", false, 35); | 513 VerifySuggestPollingStrategy(NULL, "35", false, 35); |
521 VerifySuggestPollingStrategy( | 514 VerifySuggestPollingStrategy( |
522 "true", NULL, true, | 515 "true", NULL, true, |
523 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs); | 516 OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs); |
524 } | 517 } |
OLD | NEW |