Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1584723003: Fix depth_stencil attachment for framebuffer (Closed)

Created:
4 years, 11 months ago by qiankun
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix depth_stencil attachment for framebuffer DEPTH_STENCIL_ATTACHMENT is like an alias for DEPTH_ATTACHMENT + STENCIL_ATTACHMENT in WebGL 2. This CL divides DEPTH_STENCIL_ATTACHMENT handler into combination of DEPTH_ATTACHMENT and STENCIL_ATTACHMENT. BUG=295792 Committed: https://crrev.com/bb9b9c4a1d1b5feae4163cb47dc416250fcbbfc8 Cr-Commit-Position: refs/heads/master@{#369303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +17 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
qiankun
Test is added: https://github.com/KhronosGroup/WebGL/pull/1430. PTAL.
4 years, 11 months ago (2016-01-13 17:22:41 UTC) #2
Ken Russell (switch to Gerrit)
Thanks, this LGTM.
4 years, 11 months ago (2016-01-13 19:30:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584723003/1
4 years, 11 months ago (2016-01-13 22:43:42 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) ...
4 years, 11 months ago (2016-01-14 00:51:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584723003/1
4 years, 11 months ago (2016-01-14 01:59:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:25:38 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:26:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb9b9c4a1d1b5feae4163cb47dc416250fcbbfc8
Cr-Commit-Position: refs/heads/master@{#369303}

Powered by Google App Engine
This is Rietveld 408576698