Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1584663003: Merge to XFA: Fix out of bound access in CPDF_Parser::ParseIndirectObject(). (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix out of bound access in CPDF_Parser::ParseIndirectObject(). This regressed in commit f6dafc9. BUG=576915 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1582763002 . (cherry picked from commit e02f30bb59b01c159b010fc5c6bb55e677aba8ce) Committed: https://pdfium.googlesource.com/pdfium/+/19dee922f1284294bed29b26a67cce1d2ee3a48f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 4 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
TBR, clean merge.
4 years, 11 months ago (2016-01-13 20:18:38 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as 19dee922f1284294bed29b26a67cce1d2ee3a48f (presubmit successful).
4 years, 11 months ago (2016-01-13 20:19:25 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-13 20:36:09 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698