Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1582763002: Fix out of bound access in CPDF_Parser::ParseIndirectObject(). (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix out of bound access in CPDF_Parser::ParseIndirectObject(). This regressed in commit f6dafc9. BUG=576915 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e02f30bb59b01c159b010fc5c6bb55e677aba8ce

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 4 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 11 months ago (2016-01-13 09:09:32 UTC) #3
Tom Sepez
LGTM Please add some context to the CL description, e.g. where the broke (i.e. me) ...
4 years, 11 months ago (2016-01-13 18:52:45 UTC) #4
Lei Zhang
On 2016/01/13 18:52:45, Tom Sepez wrote: > LGTM > > Please add some context to ...
4 years, 11 months ago (2016-01-13 20:11:47 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-13 20:13:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
e02f30bb59b01c159b010fc5c6bb55e677aba8ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698