Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issue 1584653004: Ensure Layers have valid sequence numbers for PropertyTrees (Closed)

Created:
4 years, 11 months ago by nyquist
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure Layers have valid sequence numbers for PropertyTrees Calling Layer::set_property_tree_sequence_number() does not set the flag that a commit is needed, which means it can quickly get out of date for layers that are not updated for other reasons when the Layer is (de)serialized. This CL makes the LayerTreeHost forcefully set the sequence number to the same value as the current PropertyTrees.sequence_number, since all valid in the hierarchy is valid at that point. BUG=577352, 538710 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b36e0d5d5100b55128ed7a2c7642afd3591a4e07 Cr-Commit-Position: refs/heads/master@{#371654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M cc/layers/layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_serialization.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
nyquist
vmpstr, dtrainor: PTAL
4 years, 11 months ago (2016-01-14 23:22:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584653004/1
4 years, 11 months ago (2016-01-14 23:22:49 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 00:30:47 UTC) #7
David Trainor- moved to gerrit
lgtm
4 years, 11 months ago (2016-01-20 17:04:08 UTC) #8
vmpstr
lgtm
4 years, 11 months ago (2016-01-26 22:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584653004/1
4 years, 11 months ago (2016-01-26 22:54:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:17:41 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:18:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b36e0d5d5100b55128ed7a2c7642afd3591a4e07
Cr-Commit-Position: refs/heads/master@{#371654}

Powered by Google App Engine
This is Rietveld 408576698