Issue 1584643002: Mojom parser: More tweaks to comments defining the grammar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1584643002: Mojom parser: More tweaks to comments defining the grammar. (Closed)

Created:
4 years, 11 months ago by rudominer

Modified:
4 years, 11 months ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Mojom parser: More tweaks to comments defining the grammar. A few more minor tweaks to comments defining the grammar. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46b3a888dda496347e2924ce41c3a301a9d0b39b

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	mojom/mojom_parser/parser/parsing.go	View		5 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rudominer

4 years, 11 months ago (2016-01-13 01:41:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
46b3a888dda496347e2924ce41c3a301a9d0b39b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages