Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1584643002: Mojom parser: More tweaks to comments defining the grammar. (Closed)

Created:
4 years, 11 months ago by rudominer
Modified:
4 years, 11 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom parser: More tweaks to comments defining the grammar. A few more minor tweaks to comments defining the grammar. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46b3a888dda496347e2924ce41c3a301a9d0b39b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M mojom/mojom_parser/parser/parsing.go View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
4 years, 11 months ago (2016-01-13 01:39:32 UTC) #3
azani
lgtm
4 years, 11 months ago (2016-01-13 01:40:19 UTC) #4
rudominer
4 years, 11 months ago (2016-01-13 01:41:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46b3a888dda496347e2924ce41c3a301a9d0b39b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698