Mojom parser: More tweaks to comments defining the grammar.

mojom/mojom_parser/parser/parsing.go

 package parser
 
 import (
         "fmt"
         "math"
         "mojom/mojom_parser/lexer"
         "mojom/mojom_parser/mojom"
         "strconv"
 )
 
@@ skipping 28 matching lines @@
 // MOJOM_FILE           -> IMPORT_STMNT {IMPORT_STMNT} {ATTR_MOJOM_DECL}
 // MOJOM_FILE           -> MOJOM_DECL {ATTR_MOJOM_DECL}
 
 // MODULE_DECL          -> module IDENTIFIER semi
 // IMPORT_STMNT         -> import string_literal
 
 // ATTR_MOJOM_DECL      -> [ATTRIBUTES] MOJOM_DECL
 // MOJOM_DECL           -> INTRFC_DECL | STRUCT_DECL | UNION_DECL | ENUM_DECL | CONSTANT_DECL
 
 // ATTRIBUTES           -> lbracket ATTR_ASSIGNMENT { comma, ATTR_ASSIGNMENT}
-// ATTR_ASSIGNMENT      -> name equals name | name equals literal
+// ATTR_ASSIGNMENT      -> name equals name | name equals LITERAL_VALUE
 
 // INTRFC_DECL          -> interface name lbrace INTRFC_BODY rbrace semi
 // INTRFC_BODY          -> {ATTR_INTRFC_ELEMENT}
 // ATTR_INTRFC_ELEMENT  -> [ATTRIBUTES] INTRFC_ELEMENT
 // INTRFC_ELEMENT       -> METHOD_DECL | ENUM_DECL | CONSTANT_DECL
 
 // METHOD_DECL          -> name [ordinal] lparen [PARAM_LIST] rparen [response lparen [PARAM_LIST] rparen] semi
-// PARAM_LIST           -> PARAM_DECL {, PARAM_DECL}
+// PARAM_LIST           -> PARAM_DECL {comma, PARAM_DECL}
 // PARAM_DECL           -> [ATTRIBUTES] TYPE NAME [ordinal]
 
 // STRUCT_DECL          -> struct name lbrace STRUCT_BODY rbrace semi
 // STRUCT_BODY          -> {ATTR_STRUCT_ELEMENT}
 // ATTR_STRUCT_ELEMENT  -> [ATTRIBUTES] STRUCT_ELEMENT
 // STRUCT_ELEMENT       -> STRUCT_FIELD | ENUM_DECL | CONSTANT_DECL
 // STRUCT_FIELD         -> TYPE name [ordinal] [equals DEFAULT_VALUE] semi
 // DEFAULT_VALUE        -> COMPATIBLE_VALUE_REF | default
-// COMPATIBLE_VALUE_REF -> VALUE_REF {{that resolves to a value whose type is assignment compatible to the type of the assignee}}
+// COMPATIBLE_VALUE_REF -> VALUE_REF {{that resolves to a concrete value whose type is assignment compatible with the type of the assignee}}
 
 // UNION_DECL           -> union name lbrace UNION_BODY rbrace semi
 // UNION_BODY           -> {UNION_FIELD_DECL}
 // UNION_FIELD_DECL     -> [ATTRIBUTES] TYPE name [ordinal] semi
 
 // ENUM_DECL            -> enum name lbrace ENUM_BODY rbrace semi
 // ENUM_BODY            -> [ ENUN_VALUE {, ENUM_VALUE} [,] ]
 // ENUM_VALUE           -> [ATTRIBUTES] name [equals ENUM_VAL_INITIALIZER]
 // ENUM_VAL_INITIALIZER -> INT32_VAL | APPROPRIATE_ENUM_VALUE_REF
-// INT32_VAL            -> VALUE_REF {{that resolves to a value of integer type that may be assigned to an int32.}}
+// INT32_VAL            -> VALUE_REF {{that resolves to a concrete value of integer type that may be assigned to an int32.}}
 // APPROPRIATE_ENUM_VALUE_REF
 //                      -> USER_VALUE_REF {{that resolves to an enum value of the same enum type as the initializee
 //                                          and which occurs earlier in declaration order than the initializee.}}
 
 // CONSTANT_DECL        -> const CONST_OK_TYPE name equals COMPATIBLE_VALUE_REF semi
 // CONST_OK_TYPE        -> SIMPLE_TYPE | string | ENUM_TYPE {{See https://github.com/domokit/mojo/issues/607}}
 
 // VALUE_REF            -> USER_VALUE_REF | LITERAL_VALUE | BUILT_IN_FLOAT_CONST
-// USER_VALUE_REF       -> IDENTIFIER {{that resolves to a user-declared constant or enum value}}
-// BUILT_IN_FLOAT_CONST -> IDENTIFIER {{that does not resolve to a user-declared constant or enum value
+// USER_VALUE_REF       -> IDENTIFIER {{that resolves to a user-defined constant or enum value}}
+// BUILT_IN_FLOAT_CONST -> IDENTIFIER {{that does not resolve to a user-defined constant or enum value
 //                         and that is equal to one of the following strings:
 //                         "float.INFINITY", "float.NEGATIVE_INFINITY", "float.NAN",
 //                         "double.INFINITY", "double.NEGATIVE_INFINITY","double.NAN"}
 // LITERAL_VALUE        -> BOOL_LITERAL | string_literal | NUMBER_LITERAL
 // BOOL_LITERAL         -> true | false
 // NUMBER_LITERAL       -> [plus | minus] POS_NUM_LITERAL
 // INTEGER_LITERAL      -> [plus | minus] POS_INT_LITERAL
 // POS_NUM_LITERAL      -> POS_INT_LITERAL | POS_FLOAT_LITERAL
 // POS_INT_LITERAL      -> int_const_dec | int_const_hex
 // POS_FLOAT_LITERAL    -> float_const
@@ skipping 1624 matching lines @@
 func (p *Parser) unexpectedTokenError(token lexer.Token, expected string) {
         var message string
         switch token.Kind {
         case lexer.ErrorUnterminatedStringLiteral, lexer.ErrorUnterminatedComment:
                 message = fmt.Sprintf("%s", token)
         default:
                 message = fmt.Sprintf("Unexpected %s. Expecting %s.", token, expected)
         }
         p.parseErrorT(ParserErrorCodeUnexpectedToken, message, token)
 }