Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1584613003: Expose stable_device_id in audio extension apis. (Closed)

Created:
4 years, 11 months ago by jennyz
Modified:
4 years, 11 months ago
Reviewers:
mnilsson, rkc
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose stable_device_id in audio extension apis. BUG=466768 Committed: https://crrev.com/2ae95ec857101c352623e6577a1c758bedcbeb66 Cr-Commit-Position: refs/heads/master@{#370730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M extensions/browser/api/audio/audio_apitest.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M extensions/browser/api/audio/audio_service_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/data/api_test/audio/add_nodes/background.js View 3 chunks +3 lines, -0 lines 0 comments Download
M extensions/test/data/api_test/audio/remove_nodes/background.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jennyz
This cl expose the stable_device_id from the cras to the audio extension api in the ...
4 years, 11 months ago (2016-01-13 19:27:09 UTC) #2
mnilsson
lgtm
4 years, 11 months ago (2016-01-20 18:51:37 UTC) #3
jennyz
rkc@, would you PTAL? I need owner's approval.
4 years, 11 months ago (2016-01-20 23:53:30 UTC) #4
rkc
lgtm
4 years, 11 months ago (2016-01-21 00:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584613003/1
4 years, 11 months ago (2016-01-21 00:04:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/168016)
4 years, 11 months ago (2016-01-21 01:24:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584613003/1
4 years, 11 months ago (2016-01-21 17:52:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 18:22:50 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 18:24:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ae95ec857101c352623e6577a1c758bedcbeb66
Cr-Commit-Position: refs/heads/master@{#370730}

Powered by Google App Engine
This is Rietveld 408576698