extensions/browser/api/audio/audio_service_chromeos.cc - Issue 1584613003: Expose stable_device_id in audio extension apis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/audio/audio_service_chromeos.cc

Issue 1584613003: Expose stable_device_id in audio extension apis. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/audio/audio_service_chromeos.cc

diff --git a/extensions/browser/api/audio/audio_service_chromeos.cc b/extensions/browser/api/audio/audio_service_chromeos.cc

index abd3f859587db1bced0a4911c06f372597b1864d..6089b88dc5df8372e78ed0f700eee3a537889c86 100644

--- a/extensions/browser/api/audio/audio_service_chromeos.cc

+++ b/extensions/browser/api/audio/audio_service_chromeos.cc

@@ -273,8 +273,8 @@ void AudioServiceImpl::NotifyDevicesChanged() {

? cras_audio_handler_->GetOutputVolumePercentForDevice(

devices[i].id)

: cras_audio_handler_->GetInputGainPercentForDevice(devices[i].id);

- // TODO(jennyz): Set stable_device_id once it is implemented.

- // See crbug.com/466768.

+ info->stable_device_id.reset(

+ new std::string(base::Uint64ToString(devices[i].stable_device_id)));

devices_info_list.push_back(info);

}